Re: [jira] [Commented] (TAP5-2588) Does not work with Java 9

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Commented] (TAP5-2588) Does not work with Java 9

Thiago H de Paula Figueiredo
Thank you very much for looking into this, Bob! By the way, does it also
cover Java 10?

Maybe, when this task is finished, we should create a 5.5 release?

Cheers!

On Sun, Jul 22, 2018 at 9:38 PM Bob Harner (JIRA) <[hidden email]> wrote:

>
>     [
> https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552200#comment-16552200
> ]
>
> Bob Harner commented on TAP5-2588:
> ----------------------------------
>
> Making progress. Unit tests finally run, though not all successfully. This
> may take another couple weekends.
>
> > Does not work with Java 9
> > -------------------------
> >
> >                 Key: TAP5-2588
> >                 URL: https://issues.apache.org/jira/browse/TAP5-2588
> >             Project: Tapestry 5
> >          Issue Type: Bug
> >          Components: plastic
> >    Affects Versions: 5.4.3
> >            Reporter: Jochen Kemnade
> >            Assignee: Bob Harner
> >            Priority: Critical
> >
> > You cannot use Tapestry with Java 9 because of an outdated ASM version
> in plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do do
> so results in a {{ClassCastException}} in
> {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values
> for array attributes}}.
> > {noformat}
> > java.lang.ClassCastException: [I cannot be cast to
> java.base/[Ljava.lang.Object;
> >       at
> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
> >       at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
> >       at
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
> >       at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
> >       at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
> >       at
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
> >       at
> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
> >       at
> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
> >       at org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit
> values for array attributes(ArrayAttributeAnnotations.groovy:27)
> > {noformat}
> > The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}} to
> an {{Object[]}}.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>


--
Thiago
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Commented] (TAP5-2588) Does not work with Java 9

bobharner
Thiago,

I don't know about Java 10 but I assume so. Java 9 has big changes
(modules), but my understanding is that Java 10 is just small stuff. And
yes, I agree, a 5.5 release should follow soon after, in my opinion.

On Tue, Jul 31, 2018, 9:07 AM Thiago H. de Paula Figueiredo <
[hidden email]> wrote:

> Thank you very much for looking into this, Bob! By the way, does it also
> cover Java 10?
>
> Maybe, when this task is finished, we should create a 5.5 release?
>
> Cheers!
>
> On Sun, Jul 22, 2018 at 9:38 PM Bob Harner (JIRA) <[hidden email]> wrote:
>
> >
> >     [
> >
> https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552200#comment-16552200
> > ]
> >
> > Bob Harner commented on TAP5-2588:
> > ----------------------------------
> >
> > Making progress. Unit tests finally run, though not all successfully.
> This
> > may take another couple weekends.
> >
> > > Does not work with Java 9
> > > -------------------------
> > >
> > >                 Key: TAP5-2588
> > >                 URL: https://issues.apache.org/jira/browse/TAP5-2588
> > >             Project: Tapestry 5
> > >          Issue Type: Bug
> > >          Components: plastic
> > >    Affects Versions: 5.4.3
> > >            Reporter: Jochen Kemnade
> > >            Assignee: Bob Harner
> > >            Priority: Critical
> > >
> > > You cannot use Tapestry with Java 9 because of an outdated ASM version
> > in plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do
> do
> > so results in a {{ClassCastException}} in
> > {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values
> > for array attributes}}.
> > > {noformat}
> > > java.lang.ClassCastException: [I cannot be cast to
> > java.base/[Ljava.lang.Object;
> > >       at
> >
> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
> > >       at
> >
> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
> > >       at
> org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit
> > values for array attributes(ArrayAttributeAnnotations.groovy:27)
> > > {noformat}
> > > The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}}
> to
> > an {{Object[]}}.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v7.6.3#76005)
> >
>
>
> --
> Thiago
>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Commented] (TAP5-2588) Does not work with Java 9

bobharner
All tests work for me under Java 8 now, with my recent commits. Only one
test fails under Java 9.0.4, which is at Tapestry-security
(TapestryHibernateIntegrationTests.java:118, "Element name not found"),
which I'll look at soon, probably in the next couple days.

On Tue, Jul 31, 2018, 6:52 PM Bob Harner <[hidden email]> wrote:

> Thiago,
>
> I don't know about Java 10 but I assume so. Java 9 has big changes
> (modules), but my understanding is that Java 10 is just small stuff. And
> yes, I agree, a 5.5 release should follow soon after, in my opinion.
>
> On Tue, Jul 31, 2018, 9:07 AM Thiago H. de Paula Figueiredo <
> [hidden email]> wrote:
>
>> Thank you very much for looking into this, Bob! By the way, does it also
>> cover Java 10?
>>
>> Maybe, when this task is finished, we should create a 5.5 release?
>>
>> Cheers!
>>
>> On Sun, Jul 22, 2018 at 9:38 PM Bob Harner (JIRA) <[hidden email]>
>> wrote:
>>
>> >
>> >     [
>> >
>> https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552200#comment-16552200
>> > ]
>> >
>> > Bob Harner commented on TAP5-2588:
>> > ----------------------------------
>> >
>> > Making progress. Unit tests finally run, though not all successfully.
>> This
>> > may take another couple weekends.
>> >
>> > > Does not work with Java 9
>> > > -------------------------
>> > >
>> > >                 Key: TAP5-2588
>> > >                 URL: https://issues.apache.org/jira/browse/TAP5-2588
>> > >             Project: Tapestry 5
>> > >          Issue Type: Bug
>> > >          Components: plastic
>> > >    Affects Versions: 5.4.3
>> > >            Reporter: Jochen Kemnade
>> > >            Assignee: Bob Harner
>> > >            Priority: Critical
>> > >
>> > > You cannot use Tapestry with Java 9 because of an outdated ASM version
>> > in plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do
>> do
>> > so results in a {{ClassCastException}} in
>> > {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values
>> > for array attributes}}.
>> > > {noformat}
>> > > java.lang.ClassCastException: [I cannot be cast to
>> > java.base/[Ljava.lang.Object;
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
>> > >       at
>> >
>> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
>> > >       at
>> org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit
>> > values for array attributes(ArrayAttributeAnnotations.groovy:27)
>> > > {noformat}
>> > > The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}}
>> to
>> > an {{Object[]}}.
>> >
>> >
>> >
>> > --
>> > This message was sent by Atlassian JIRA
>> > (v7.6.3#76005)
>> >
>>
>>
>> --
>> Thiago
>>
>