TAP5 (Support pseudo nested JPA transactions) merged

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

TAP5 (Support pseudo nested JPA transactions) merged

Kalle Korhonen-2
I just pushed a new JPA feature for T5.5, see
https://github.com/apache/tapestry5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f.
There's one issue though - I had to add annotations to a test service
*interface* (UserDAO) to make one test, specifically
JpaIntegrationTestWithAnnotationsInServiceImplementation work. I'm really
not sure why at this point but I wanted to push it now for all to take a
look at. I'm pretty sure it has something to do with the advice
implementation, what's wrong with
https://github.com/apache/tapestry5/blob/master/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
?

Additionally, are you guys able to run the Selenium integrations
successfully from the IDE? I am not, not sure why and it makes it awfully
hard to debug.

Kalle
Reply | Threaded
Open this post in threaded view
|

Re: TAP5 (Support pseudo nested JPA transactions) merged

Kalle Korhonen-2
Somehow I left the issue number out from the title - it's TAP5-2553
<https://issues.apache.org/jira/browse/TAP5-2553>.

Kalle

On Wed, Jun 8, 2016 at 11:02 AM, Kalle Korhonen <[hidden email]>
wrote:

> I just pushed a new JPA feature for T5.5, see
> https://github.com/apache/tapestry5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f.
> There's one issue though - I had to add annotations to a test service
> *interface* (UserDAO) to make one test, specifically
> JpaIntegrationTestWithAnnotationsInServiceImplementation work. I'm really
> not sure why at this point but I wanted to push it now for all to take a
> look at. I'm pretty sure it has something to do with the advice
> implementation, what's wrong with
> https://github.com/apache/tapestry5/blob/master/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
> ?
>
> Additionally, are you guys able to run the Selenium integrations
> successfully from the IDE? I am not, not sure why and it makes it awfully
> hard to debug.
>
> Kalle
>
Reply | Threaded
Open this post in threaded view
|

Re: TAP5 (Support pseudo nested JPA transactions) merged

Thiago H de Paula Figueiredo
In reply to this post by Kalle Korhonen-2
Yay! Thanks, Kalle!

On Wed, 08 Jun 2016 15:02:30 -0300, Kalle Korhonen  
<[hidden email]> wrote:

> I just pushed a new JPA feature for T5.5, see
> https://github.com/apache/tapestry5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f.
> There's one issue though - I had to add annotations to a test service
> *interface* (UserDAO) to make one test, specifically
> JpaIntegrationTestWithAnnotationsInServiceImplementation work. I'm really
> not sure why at this point but I wanted to push it now for all to take a
> look at. I'm pretty sure it has something to do with the advice
> implementation, what's wrong with
> https://github.com/apache/tapestry5/blob/master/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
> ?

Weird, the annotation copying from service implementation to proxy has a  
lot of unit tests covering a lot of cases, including some corner ones that  
were filed by users.

> Additionally, are you guys able to run the Selenium integrations
> successfully from the IDE? I am not, not sure why and it makes it awfully
> hard to debug.

Selenium is discontinued as far as I know.

--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: TAP5 (Support pseudo nested JPA transactions) merged

Kalle Korhonen-2
On Thu, Jun 9, 2016 at 3:40 PM, Thiago H de Paula Figueiredo <
[hidden email]> wrote:

> On Wed, 08 Jun 2016 15:02:30 -0300, Kalle Korhonen <
> [hidden email]> wrote:
>
>> I just pushed a new JPA feature for T5.5, see
>>
>> https://github.com/apache/tapestry5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f
>> .
>> There's one issue though - I had to add annotations to a test service
>> *interface* (UserDAO) to make one test, specifically
>> JpaIntegrationTestWithAnnotationsInServiceImplementation work. I'm really
>> not sure why at this point but I wanted to push it now for all to take a
>> look at. I'm pretty sure it has something to do with the advice
>> implementation, what's wrong with
>>
>> https://github.com/apache/tapestry5/blob/master/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
>> ?
>>
> Weird, the annotation copying from service implementation to proxy has a
> lot of unit tests covering a lot of cases, including some corner ones that
> were filed by users.


I've been doing this long enough that I know the likeliest source of a bug
is in my own code :) Just didn't see one now but oh well, I'll dig it out.

>
> Additionally, are you guys able to run the Selenium integrations
>> successfully from the IDE? I am not, not sure why and it makes it awfully
>> hard to debug.
>>
> Selenium is discontinued as far as I know.


What? That's news to me, can you provide a reference? I tell you, so many
parts of Tapestry are so elegant, but testing both with Easymock and
Selenium sometimes feels arcane to me compared to Geb, Mockito and HtmlUnit
(and no, not signing up to rewrite the 1500 tests we have...).

Kalle
Reply | Threaded
Open this post in threaded view
|

Re: TAP5 (Support pseudo nested JPA transactions) merged

Thiago H de Paula Figueiredo
On Fri, 10 Jun 2016 03:11:33 -0300, Kalle Korhonen  
<[hidden email]> wrote:

> I've been doing this long enough that I know the likeliest source of a  
> bug is in my own code :) Just didn't see one now but oh well, I'll dig  
> it out.

And if you find your code is correct but mine isn't, please let me know so  
I can fix it. ;)

>> Selenium is discontinued as far as I know.
>
>
> What? That's news to me, can you provide a reference? I tell you, so many
> parts of Tapestry are so elegant, but testing both with Easymock and
> Selenium sometimes feels arcane to me compared to Geb, Mockito and  
> HtmlUnit
> (and no, not signing up to rewrite the 1500 tests we have...).

Well, Selenium RC, the API the most of our Tapestry tests use, is  
deprecated, and Selenium WebDriver is its replacement. There's  
WebDriverBackedSelenium, a Selenium RC interface based on WebDriver, which  
we could try to use in our tests. Selenium 3.0 will remove the RC API  
completely.

--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]